fix: improve report push notification on click #17710
Open
+32
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuran-deriv
requested review from
heorhi-deriv,
nijil-deriv,
vinu-deriv,
sandeep-deriv and
shafin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mayuran-deriv
changed the title
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-mayuran-deriv-mayuran-improvereportclick.binary.sx/ |
shafin-deriv
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the Reports link, the page redirects to reports/positions. However, the redirection does not carry the correct trade type. For example, if the user clicks on a Reports link associated with Accumulators, the page still redirects to reports/positions with the default trade type set to Options. This results in an error message stating "No contract positions", which can be misleading for the user.
Expected Behavior:
The redirection to reports/positions should reflect the context of the selected trade type. For instance:
If the user clicks on a Reports link for Accumulators, the reports/positions page should display Accumulators as the selected trade type and load relevant contract positions (if available).
Similarly, if the user clicks on a link associated with Multipliers, the page should display Multipliers as the selected trade type.