Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRAH]/Hasan/[TRAH-4541]/Gold Account in compare account table #17737

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Conversation

hasan-deriv
Copy link
Contributor

@hasan-deriv hasan-deriv commented Dec 5, 2024

Changes:

  • Added gold account to compare accounts table for both EU and Non-EU

Screenshots:

EU:

Screenshot 2024-12-06 at 3 35 17 PM Screenshot 2024-12-06 at 3 35 36 PM

Non-EU:

Screenshot 2024-12-06 at 3 36 22 PM Screenshot 2024-12-06 at 3 36 44 PM

Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 12, 2024 5:40am

Copy link
Contributor

github-actions bot commented Dec 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17737](https://github.com/deriv-com/deriv-app/pull/17737)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hasan-deriv-hasan-compare-accounts-gold.binary.sx?qa_server=red.derivws.com&app_id=23848
    - **Original**: https://deriv-app-git-fork-hasan-deriv-hasan-compare-accounts-gold.binary.sx
- **App ID**: `23848`

Copy link
Contributor

github-actions bot commented Dec 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 43
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-hasan-deriv-hasan-compare-accounts-gold.binary.sx/

@coveralls
Copy link

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12290342476

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 13 of 24 (54.17%) changed or added relevant lines in 3 files are covered.
  • 1056 unchanged lines in 33 files lost coverage.
  • Overall coverage decreased (-0.02%) to 53.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/cfd/src/Containers/cfd-compare-accounts/cfd-instruments-label-highlighted.tsx 0 1 0.0%
packages/cfd/src/Helpers/compare-accounts-config.ts 10 20 50.0%
Files with Coverage Reduction New Missed Lines %
packages/cfd/src/Containers/cfd-compare-accounts/cfd-instruments-label-highlighted.tsx 1 70.0%
packages/cfd/src/Helpers/compare-accounts-config.ts 1 62.92%
packages/core/src/App/Containers/app-notification-messages.jsx 1 67.16%
packages/stores/src/mockStore.ts 1 0.0%
packages/trader/src/AppV2/Components/Guide/guide-description-modal.tsx 1 86.36%
packages/trader/src/AppV2/Components/OnboardingGuide/GuideForPages/guide-tooltip.tsx 1 76.47%
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 1 87.07%
packages/trader/src/index.tsx 1 0.0%
packages/wallets/src/features/cfd/screens/MT5TradeScreen/MT5TradeLink/MT5TradeLink.tsx 1 94.23%
packages/trader/src/AppV2/Components/TradeParameters/Duration/container.tsx 2 94.83%
Totals Coverage Status
Change from base Build 12190387633: -0.02%
Covered Lines: 32985
Relevant Lines: 57046

💛 - Coveralls

@hasan-deriv hasan-deriv changed the title fix: add product to create unique key [TRAH]/Hasan/[TRAH-4541]/Gold Account in compare account table Dec 6, 2024
@hasan-deriv hasan-deriv marked this pull request as ready for review December 6, 2024 08:44
amam-deriv
amam-deriv previously approved these changes Dec 6, 2024
Copy link
Contributor

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine, but have small suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants