-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove localstorage-sync #17749
base: master
Are you sure you want to change the base?
chore: remove localstorage-sync #17749
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12192641630Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-remove-lo-820e12.binary.sx/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
This pull request includes several changes to clean up and simplify the codebase by removing unused components and redundant code. The most important changes include removing the
P2PIFrame
andSmartTraderIFrame
components, as well as the associated local storage synchronization functionality.The loaclstorage-sync is no longer required as the backend (BE) is now responsible for managing account syncing between the parent (Deriv App) and child applications. Currently, the frontend (FE) is implementing logic to set localStorage tokens and account information for child apps, but this is redundant and can be eliminated.
Codebase simplification:
packages/core/src/App/AppContent.tsx
: Removed unused imports and theP2PIFrame
andSmartTraderIFrame
components. [1] [2]packages/core/src/Modules/P2PIFrame/P2PIFrame.tsx
: Deleted theP2PIFrame
component.packages/core/src/Modules/SmartTraderIFrame/SmartTraderIFrame.jsx
: Deleted theSmartTraderIFrame
component.packages/core/src/root_files/localstorage-sync.html
: Removed thelocalstorage-sync.html
file.Removal of local storage synchronization:
packages/core/src/Stores/client-store.js
: Removed thesyncWithLegacyPlatforms
method and its calls throughout theClientStore
class. [1] [2] [3] [4] [5] [6] [7] [8]## Changes:Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.