Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove localstorage-sync #17749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Dec 6, 2024

This pull request includes several changes to clean up and simplify the codebase by removing unused components and redundant code. The most important changes include removing the P2PIFrame and SmartTraderIFrame components, as well as the associated local storage synchronization functionality.

The loaclstorage-sync is no longer required as the backend (BE) is now responsible for managing account syncing between the parent (Deriv App) and child applications. Currently, the frontend (FE) is implementing logic to set localStorage tokens and account information for child apps, but this is redundant and can be eliminated.

Codebase simplification:

Removal of local storage synchronization:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 6, 2024 4:15am

@coveralls
Copy link

coveralls commented Dec 6, 2024

Pull Request Test Coverage Report for Build 12192641630

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 53.936%

Files with Coverage Reduction New Missed Lines %
packages/core/src/App/AppContent.tsx 1 0.0%
Totals Coverage Status
Change from base Build 12190387633: 0.02%
Covered Lines: 32950
Relevant Lines: 56949

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 6, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17749](https://github.com/deriv-com/deriv-app/pull/17749)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-remove-lo-820e12.binary.sx?qa_server=red.derivws.com&app_id=23939
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-remove-lo-820e12.binary.sx
- **App ID**: `23939`

Copy link
Contributor

github-actions bot commented Dec 6, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-remove-lo-820e12.binary.sx/

Copy link
Contributor

@amam-deriv amam-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants