-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amina/fix: redirection_test #17779
base: master
Are you sure you want to change the base?
Amina/fix: redirection_test #17779
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Pull Request Test Coverage Report for Build 12277856673Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx/ |
@@ -65,7 +65,9 @@ const ListItem = observer(({ id, text, status, route }: TListItemProps) => { | |||
if (id === 'address' && status) { | |||
localStorage.setItem('mt5_poa_status', String(status)); | |||
} | |||
history.push(route); | |||
// history.push(route); | |||
window.open(route, '_blank'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make this secure and ask permission ->
const newWindow = window.open(url, "_blank","noopener,noreferrer");
// Check if the new window was blocked by a pop-up blocker
if (!newWindow) {
alert("Pop-up blocked! Please allow pop-ups for this website.");
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add noopener,noreferrer
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.