Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amina/fix: redirection_test #17779

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 11, 2024 2:20pm

@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12277856673

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 15 (93.33%) changed or added relevant lines in 3 files are covered.
  • 606 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 53.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/appstore/src/components/modals/verification-docs-list-modal/ListItem.tsx 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
packages/core/src/App/Containers/app-notification-messages.jsx 1 67.16%
packages/trader/src/AppV2/Components/Guide/guide-description-modal.tsx 1 86.36%
packages/trader/src/AppV2/Hooks/useContractsForCompany.ts 1 87.07%
packages/wallets/src/features/cfd/screens/MT5TradeScreen/MT5TradeLink/MT5TradeLink.tsx 1 94.23%
packages/trader/src/AppV2/Components/TradeParameters/Duration/container.tsx 2 94.83%
packages/core/src/App/Containers/SettingsModal/settings-language.jsx 3 20.0%
packages/wallets/src/features/cfd/constants.tsx 3 75.0%
packages/core/src/App/Components/Layout/Header/platform-dropdown.jsx 5 65.91%
packages/bot-web-ui/src/stores/quick-strategy-store.ts 6 82.95%
packages/core/src/App/Components/Layout/Header/Components/ToggleMenu/mobile-language-menu.tsx 7 9.09%
Totals Coverage Status
Change from base Build 12235374815: 0.02%
Covered Lines: 33000
Relevant Lines: 57051

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17779](https://github.com/deriv-com/deriv-app/pull/17779)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx?qa_server=red.derivws.com&app_id=32210
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx
- **App ID**: `32210`

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 38
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx/

@@ -65,7 +65,9 @@ const ListItem = observer(({ id, text, status, route }: TListItemProps) => {
if (id === 'address' && status) {
localStorage.setItem('mt5_poa_status', String(status));
}
history.push(route);
// history.push(route);
window.open(route, '_blank');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make this secure and ask permission ->

 const newWindow = window.open(url, "_blank","noopener,noreferrer");
    // Check if the new window was blocked by a pop-up blocker
    if (!newWindow) {
        alert("Pop-up blocked! Please allow pop-ups for this website.");
    }

Copy link
Contributor

@likhith-deriv likhith-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add noopener,noreferrer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants