Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P2PS] / Ameerul / P2PS-4586 Remove p2p package from deriv-app #17785

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[P2PS] / Ameerul / P2PS-4586 Remove p2p package from deriv-app #17785

wants to merge 11 commits into from

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Removed p2p package from deriv-app
  • Removed custom p2p hooks
  • Removed any p2p store variables from any stores, components
  • Removed p2p notifications
  • Always show p2p tab in cashier and toggle menu drawer, all of the logic to show p2p is handled internally in standalone application

Screenshots:

Please provide some screenshots of the change.

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 12, 2024 8:46am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17785](https://github.com/deriv-com/deriv-app/pull/17785)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-4586-remove-p2p-pa-7d2910.binary.sx?qa_server=red.derivws.com&app_id=24204
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-4586-remove-p2p-pa-7d2910.binary.sx
- **App ID**: `24204`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-4586-remove-p2p-pa-7d2910.binary.sx/

ameerul-deriv
ameerul-deriv commented Dec 11, 2024
View reviewed changes
packages/cashier/src/containers/cashier/cashier.tsx
Comment on lines -208 to -222
useEffect(() => {
if (is_p2p_enabled_success && !is_p2p_enabled && history.location.pathname.startsWith(routes.cashier_p2p)) {
const url_params = new URLSearchParams(history.location.search);
const advert_id = url_params.get('advert_id');

history.push(routes.cashier_deposit);

if (advert_id) {
if (is_virtual) {
toggleReadyToDepositModal();
} else {
error.setErrorMessage({
code: 'ShareMyAdsError',
message:
currency !== 'USD' && is_svg
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all related to share my ads edge cases, so this can be removed. here is the figma file: https://www.figma.com/design/4MOUx8arWrBnUJvA3LufAh/branch/bTQkniOz9NeT3fXVFXs1Ns/P2P---My-ads?node-id=21750-322071&node-type=instance&t=g2DYm5qkh9mhZwf7-0

Screenshot 2024-12-11 at 11 31 07 AM Screenshot 2024-12-11 at 11 31 33 AM Screenshot 2024-12-11 at 11 31 37 AM

ameerul-deriv
ameerul-deriv commented Dec 11, 2024
View reviewed changes
...es/cashier-onboarding/components/cashier-onboarding-p2p-card/cashier-onboarding-p2p-card.tsx
@@ -43,8 +35,6 @@ const CashierOnboardingP2PCard: React.FC = observer(() => {
history.push('/cashier/p2p');
};

if (!should_show_p2p_card) return null;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed any logic that checks whether or not we should display p2p in the toggle-menu-drawer under cashier or under cashier tabs. This is because we already handle if the user can view p2p or not within the standalone application already. Also we should still show p2p exists, even if the user can't use it, this was an earlier suggestion from jy a long time back, since how will users know certain applications exist within deriv if we never see it

@ameerul-deriv ameerul-deriv marked this pull request as ready for review December 11, 2024 06:33
farrah-deriv
farrah-deriv reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@farrah-deriv farrah-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will also need to remove the deep linking in apple-app-site-association and assetslinks files after we release the BE card.

farrah-deriv
farrah-deriv previously approved these changes Dec 12, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-deriv jim-deriv jim-deriv approved these changes

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv left review comments

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nada-deriv nada-deriv Awaiting requested review from nada-deriv nada-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@dan-deriv dan-deriv Awaiting requested review from dan-deriv dan-deriv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ameerul-deriv @farrah-deriv @heorhi-deriv @jim-deriv @nada-deriv