Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DTRA-V2]/Ahmad/Barrier spot fix #17793

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ahmadtaimoor-deriv
Copy link
Contributor

@ahmadtaimoor-deriv ahmadtaimoor-deriv commented Dec 11, 2024

Changes:

This PR adjust the behavior of barrier . Now if we have any of the barrier select like +1.0 , -1.0 , 1.0 . (Above spot , below spot, fixed price). if one is set , the other input fields are empty without showing any error message .

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Dec 11, 2024 8:21am

Copy link
Contributor

github-actions bot commented Dec 11, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17793](https://github.com/deriv-com/deriv-app/pull/17793)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fbarrierspotfix.binary.sx?qa_server=red.derivws.com&app_id=32878
    - **Original**: https://deriv-app-git-fork-ahmadtaimoor-deriv-fbarrierspotfix.binary.sx
- **App ID**: `32878`

Copy link
Contributor

github-actions bot commented Dec 11, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ahmadtaimoor-deriv-fbarrierspotfix.binary.sx/

@coveralls
Copy link

coveralls commented Dec 11, 2024

Pull Request Test Coverage Report for Build 12271909452

Details

  • 17 of 28 (60.71%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 53.908%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx 17 28 60.71%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/App/Components/Elements/market-countdown-timer.tsx 1 83.7%
packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx 5 71.76%
Totals Coverage Status
Change from base Build 12259060491: -0.02%
Covered Lines: 32954
Relevant Lines: 56984

💛 - Coveralls

onClose: (val: boolean) => void;
}) => {
const { barrier_1, onChange, validation_errors, tick_data, setV2ParamsInitialValues } = useTraderStore();
({ isDays, onClose, is_open }: { isDays: boolean; onClose: () => void; is_open: boolean }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
({ isDays, onClose, is_open }: { isDays: boolean; onClose: () => void; is_open: boolean }) => {
({ is_days, onClose, is_open }: { isDays: boolean; onClose: () => void; is_open: boolean }) => {

For consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants