Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966

aswathy-deriv · 2025-01-09T12:08:59Z

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

vercel · 2025-01-09T12:09:04Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Jan 14, 2025 1:47pm

github-actions · 2025-01-10T14:01:12Z

A production App ID was automatically generated for this PR. (log)

PR: Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-aswathy-deriv-loggedinresidenceissue.binary.sx?qa_server=red.derivws.com&app_id=32466
- Original: https://deriv-app-git-fork-aswathy-deriv-loggedinresidenceissue.binary.sx
App ID: 32466

Click here to copy & paste above information.

- **PR**: [https://github.com/deriv-com/deriv-app/pull/17966](https://github.com/deriv-com/deriv-app/pull/17966)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aswathy-deriv-loggedinresidenceissue.binary.sx?qa_server=red.derivws.com&app_id=32466
    - **Original**: https://deriv-app-git-fork-aswathy-deriv-loggedinresidenceissue.binary.sx
- **App ID**: `32466`

github-actions · 2025-01-10T15:24:17Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	27
🟧 Accessibility	70
🟧 Best practices	83
🟧 SEO	77
🟧 PWA	78

Lighthouse ran with https://deriv-app-git-fork-aswathy-deriv-loggedinresidenceissue.binary.sx/

packages/core/src/Utils/Analytics/index.ts

shayan-deriv · 2025-01-14T07:13:02Z

packages/hooks/src/useOauth2.ts

+                    },
+                };
+                Analytics.setAttributes(analytics_config_config);
+                await Analytics?.initialise(config);


[Q]: why do we need to initialize the whole Analytics package again? 🤔 only updating the attributes would be enough.

It will work only when we re-initialize it for the logout session.can you check it and let me know if it is possible in any other way.

I'm looking into this. will update you on this

amina-deriv · 2025-01-15T04:31:39Z

packages/core/src/Utils/Analytics/index.ts


-            const client_information = Cookies.getJSON('client_information');
+            const client_information = Cookies.get('client_information')
+                ? JSON.parse(Cookies.get('client_information') || '')


we are checking if cookie exists in line 31. So do we need || '' in line 32 again?

amina-deriv · 2025-01-15T04:38:38Z

packages/hooks/src/useOauth2.ts

+        if (process.env.REMOTE_CONFIG_URL) {
+            const flags = await fetch(process.env.REMOTE_CONFIG_URL)
+                .then(res => res.json())
+                .catch(() => FIREBASE_INIT_DATA);


why do we need this whole initialization again?

The attributes are not getting updated without initialization.we can check if there is a way without doing the initialization again.

amina-deriv · 2025-01-15T04:47:21Z

packages/core/src/Utils/Analytics/index.ts

                    },
                },
            };
            await Analytics?.initialise(config);
+            Analytics.setAttributes(analytics_config_config);


What is the use of setAttributes here? we have initialized growthbook with same config in line 65
and nothing changed in attributes.

shayan-deriv · 2025-01-31T07:15:25Z

We can close this PR in favor of PR #18037

fix: loggedin value is set to false and reidence to null

d72be58

aswathy-deriv requested review from amina-deriv, balakrishna-deriv, farrah-deriv, habib-deriv, matin-deriv, nijil-deriv, sandeep-deriv and yashim-deriv as code owners January 9, 2025 12:09

aswathy-deriv had a problem deploying to Preview January 9, 2025 12:09 — with GitHub Actions Failure

aswathy-deriv changed the title ~~Aswathy/fix: loggedin value is set to false and reidence to null~~ Aswathy/fix: loggedin value is set to false and residence to null Jan 9, 2025

aswathy-deriv changed the title ~~Aswathy/fix: loggedin value is set to false and residence to null~~ Aswathy/Incorrect Logged-In Status and Missing Residence Country in Growthbook Jan 9, 2025

aswathy-deriv changed the title ~~Aswathy/Incorrect Logged-In Status and Missing Residence Country in Growthbook~~ Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook Jan 9, 2025

fix: updated the logout method

2d15136

aswathy-deriv had a problem deploying to Preview January 10, 2025 14:01 — with GitHub Actions Failure

aswathy-deriv had a problem deploying to Preview January 10, 2025 14:02 — with GitHub Actions Failure

fix: build issue

3dc9292

aswathy-deriv temporarily deployed to Preview January 10, 2025 15:00 — with GitHub Actions Inactive

aswathy-deriv temporarily deployed to Preview January 10, 2025 15:01 — with GitHub Actions Inactive

fix: logged out boolean setting issue

50ce7c7

aswathy-deriv temporarily deployed to Preview January 14, 2025 04:49 — with GitHub Actions Inactive

aswathy-deriv deployed to Preview January 14, 2025 04:50 — with GitHub Actions View deployment

shayan-deriv reviewed Jan 14, 2025

View reviewed changes

fix: peer comments

70f0e98

vercel bot deployed to Preview January 14, 2025 13:47 View deployment

amina-deriv reviewed Jan 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966

Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966

aswathy-deriv commented Jan 9, 2025

vercel bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

shayan-deriv Jan 14, 2025

aswathy-deriv Jan 14, 2025

shayan-deriv Jan 15, 2025

amina-deriv Jan 15, 2025

amina-deriv Jan 15, 2025

aswathy-deriv Jan 15, 2025

amina-deriv Jan 15, 2025 •

edited

Loading

shayan-deriv commented Jan 31, 2025

Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966

Are you sure you want to change the base?

Aswathy/fix: Incorrect Logged-In Status and Missing Residence Country in Growthbook #17966

Conversation

aswathy-deriv commented Jan 9, 2025

Changes:

Screenshots:

vercel bot commented Jan 9, 2025 • edited Loading

github-actions bot commented Jan 10, 2025 • edited Loading

github-actions bot commented Jan 10, 2025 • edited Loading

shayan-deriv Jan 14, 2025

Choose a reason for hiding this comment

aswathy-deriv Jan 14, 2025

Choose a reason for hiding this comment

shayan-deriv Jan 15, 2025

Choose a reason for hiding this comment

amina-deriv Jan 15, 2025

Choose a reason for hiding this comment

amina-deriv Jan 15, 2025

Choose a reason for hiding this comment

aswathy-deriv Jan 15, 2025

Choose a reason for hiding this comment

amina-deriv Jan 15, 2025 • edited Loading

Choose a reason for hiding this comment

shayan-deriv commented Jan 31, 2025

vercel bot commented Jan 9, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025 •

edited

Loading

amina-deriv Jan 15, 2025 •

edited

Loading