This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
Fasih/DPROD-3003/Added heading option and removed content #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
4ed090d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d19ad2a.deriv-com-v2.pages.dev |
| Branch Preview URL: | https://pr-3003-fix-hero-and-update.deriv-com-v2.pages.dev |
jia-deriv
previously approved these changes
Mar 11, 2024
habib-deriv
previously approved these changes
Mar 12, 2024
Nuzhy-Deriv
previously approved these changes
Mar 12, 2024
jia-deriv
previously approved these changes
Mar 12, 2024
hasan-deriv
previously requested changes
Mar 12, 2024
| {content && ( | ||
| <> | ||
| <div className="absolute inset-50 z-10 bg-cta-gradient lg:bg-none"></div> | ||
| <div className="-z-10 h-full w-full overflow-hidden object-cover object-top max-lg:absolute lg:relative "> |
There was a problem hiding this comment.
Why are we using max-lg?
There was a problem hiding this comment.
Suggested change
| <div className="-z-10 h-full w-full overflow-hidden object-cover object-top max-lg:absolute lg:relative "> | |
| <div className="-z-10 h-full w-full overflow-hidden object-cover object-top absolute lg:relative "> |
There was a problem hiding this comment.
Hi @meenakshi-deriv can you please help to check @hasan-deriv's question ?
Comment on lines
46
to
49
| <Heading.H2 className="hidden lg:block">{title}</Heading.H2> | ||
| <Heading.H2 className="z-20 block text-solid-slate-50 max-sm:w-full sm:w-[350px] lg:hidden lg:w-full"> | ||
| {title} | ||
| </Heading.H2> |
There was a problem hiding this comment.
Why two heading? and why max-sm?
There was a problem hiding this comment.
Hi @meenakshi-deriv can you please help to check @hasan-deriv's question ?
There was a problem hiding this comment.
Suggested change
| <Heading.H2 className="hidden lg:block">{title}</Heading.H2> | |
| <Heading.H2 className="z-20 block text-solid-slate-50 max-sm:w-full sm:w-[350px] lg:hidden lg:w-full"> | |
| {title} | |
| </Heading.H2> | |
| <Heading.H2 className="hidden lg:block">{title}</Heading.H2> | |
| <Heading.H2 className="z-20 block text-solid-slate-50 w-full sm:w-[350px] lg:hidden"> | |
| {title} | |
| </Heading.H2> |
There was a problem hiding this comment.
hi @hasan-deriv this is because some tailwind classes were not applying on deriv-hk-gold. we tried many ways but only this approach fixed the issue.
fasihali-deriv
dismissed stale reviews from jia-deriv, Nuzhy-Deriv, and habib-deriv
via
f0f8cbc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix heading option and removed content prop for hero.contentless block