[DTRA] Maryia/FEQ-1465/TrackJS error '404 : GET https://smarttrader.deriv.com/en/user/top_up_virtual_pop_up.html & dialog.html #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryia-deriv
changed the title
|
Preview Link: https://pr-611.smarttrader-preview.pages.dev
|
kate-deriv
approved these changes
Feb 16, 2024
henry-deriv
reviewed
Feb 19, 2024
| @@ -15,7 +15,7 @@ const showPopup = (options) => { | |||
| } | |||
| if (cache[options.url]) { | |||
| callback(options); | |||
| } else { | |||
| } else if (options.url) { | |||
There was a problem hiding this comment.
how could options.url trigger since its commented out ?
There was a problem hiding this comment.
we need this condition because we don't want the code below to get executed if there is no options.url (e.g. when it's commented out like in our case).
ahmadtaimoor-deriv
approved these changes
Feb 19, 2024
akmal-deriv
approved these changes
Feb 19, 2024
henry-deriv
approved these changes
Feb 19, 2024
farhan-nurzi-deriv
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
To fix TrackJS error '404 : GET https://smarttrader.deriv.com/en/user/top_up_virtual_pop_up.html' by preventing the XMLHttp request for an unused 'user/top_up_virtual_pop_up' URL and by preventing appending an unavailable TopUpVirtualPopup node to the DOM.
This also fixes another TrackJS error '404 : GET https://smarttrader.deriv.com/en/dialog.html' by preventing the XMLHttp request for an unused 'dialog' URL and by preventing appending an unavailable Dialog node to the DOM.
Type of change