Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DTRA] Farhan/DTRA-912/A console error is appearing after purchasing a trade in the staging environment of SmartTrader. #620

Merged
merged 1 commit into from
Mar 29, 2024
Merged

[DTRA] Farhan/DTRA-912/A console error is appearing after purchasing a trade in the staging environment of SmartTrader. #620

merged 1 commit into from
Mar 29, 2024

Conversation

farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Mar 14, 2024 •
edited
Loading

Changes:

  • Change redraw option to false since redraw throws error after chart initialization (probably because it doesnt work if chart is not dirty)

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@farhan-nurzi-deriv farhan-nurzi-deriv requested a review from a team as a code owner March 14, 2024 04:43
@github-actions GitHub Actions
Copy link

Preview Link: https://pr-620.smarttrader-preview.pages.dev

Name Result
Build status Completed ✅
Preview URL Visit Preview
Action URL Visit Action

@balakrishna-deriv balakrishna-deriv merged commit d16548e into deriv-com:master Mar 29, 2024
3 checks passed
@balakrishna-deriv balakrishna-deriv mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@akmal-deriv akmal-deriv akmal-deriv approved these changes

@henry-deriv henry-deriv henry-deriv approved these changes

@kate-deriv kate-deriv kate-deriv approved these changes

@ahmadtaimoor-deriv ahmadtaimoor-deriv ahmadtaimoor-deriv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@farhan-nurzi-deriv @balakrishna-deriv @akmal-deriv @henry-deriv @kate-deriv @ahmadtaimoor-deriv @Farhan-slurrp