Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename the card to advanced-camera-card #1873

Merged
merged 2 commits into from
Feb 7, 2025
Merged

feat: Rename the card to advanced-camera-card #1873

merged 2 commits into from
Feb 7, 2025

Conversation

dermotduffy
Copy link
Owner

@dermotduffy dermotduffy commented Feb 6, 2025

Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate.

This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment.

BREAKING CHANGE: References to frigate-card in all kinds of configuration need to be updated to advanced-camera-card. An automated config upgrade should take care of the majority of usecases (click Edit -> Upgrade -> Save), though may not be perfect.

Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate.

This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment.

- Closes #1298

BREAKING CHANGE: References to `frigate-card` in all kinds of configuration need to be updated to `advanced-camera-card`. An automated config upgrade should take care of the majority of usecases (click Edit -> Upgrade -> Save), though may not be perfect.
@github-actions github-actions bot added the refactoring Refactoring label Feb 6, 2025
@dermotduffy dermotduffy changed the title refactor: Rename the card to advanced-camera-card feat: Rename the card to advanced-camera-card Feb 6, 2025
@github-actions github-actions bot added feature New feature or request and removed refactoring Refactoring labels Feb 6, 2025
@felipecrs
Copy link
Contributor

Exciting!

@dermotduffy dermotduffy merged commit cc376a8 into main Feb 7, 2025
2 checks passed
Copy link

github-actions bot commented Feb 7, 2025

🎉 This issue has been resolved in version 7.0.0 🎉

See: GitHub release

@felipecrs
Copy link
Contributor

felipecrs commented Feb 7, 2025

One suggestion is to first remove the card from HACS, reload HACS, and then install it again rather than updating it. Otherwise, it will not remove some leftovers.

chrome_Tm31T8bemQ.mp4

@felipecrs
Copy link
Contributor

But according to my tests, the following still needs to be removed manually:

image

@kohbo
Copy link

kohbo commented Feb 12, 2025

One suggestion is to first remove the card from HACS, reload HACS, and then install it again rather than updating it. Otherwise, it will not remove some leftovers.
chrome_Tm31T8bemQ.mp4

I did this but HACS still says the resource will be located at frigate-hass-card

@felipecrs
Copy link
Contributor

felipecrs commented Feb 12, 2025

Have you reloaded HACS? Restarting Home Assistant should also do the trick.

@kohbo
Copy link

kohbo commented Feb 12, 2025

Have you reloaded HACS? Restarting Home Assistant should also do the trick.

After restarting HASS and then removing and adding the card again it now shows the right path. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta: Should this card be renamed?
3 participants