-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Rename the card to advanced-camera-card
#1873
Conversation
Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate. This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment. - Closes #1298 BREAKING CHANGE: References to `frigate-card` in all kinds of configuration need to be updated to `advanced-camera-card`. An automated config upgrade should take care of the majority of usecases (click Edit -> Upgrade -> Save), though may not be perfect.
advanced-camera-card
advanced-camera-card
Exciting! |
🎉 This issue has been resolved in version 7.0.0 🎉 See: GitHub release |
One suggestion is to first remove the card from HACS, reload HACS, and then install it again rather than updating it. Otherwise, it will not remove some leftovers. chrome_Tm31T8bemQ.mp4 |
I did this but HACS still says the resource will be located at frigate-hass-card |
Have you reloaded HACS? Restarting Home Assistant should also do the trick. |
After restarting HASS and then removing and adding the card again it now shows the right path. Thanks! |
Whilst the Frigate support in this card is the best among camera engines, the name incorrectly suggests that Frigate is a requirement. Instead, to broaden the appeal, change to more camera agnostic name. This does not suggest any change in priority, role or support for Frigate.
This change is likely to be bug prone, due to the size of the rename -- the code contains 1500+ references to "Frigate" most of which make sense to rename, some which do not, all of which needed human assessment.
BREAKING CHANGE: References to
frigate-card
in all kinds of configuration need to be updated toadvanced-camera-card
. An automated config upgrade should take care of the majority of usecases (clickEdit -> Upgrade -> Save
), though may not be perfect.