forked from cli/cli
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cl#2 #1
Merged
Merged
Cl#2 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support `GH_ACCEPTANCE_SCRIPT` env var to target a single script
Ensure Acceptance defer failures are debuggable
Co-authored-by: Kynan Ware <[email protected]>
Add acceptance task to makefile
Co-authored-by: Andy Feller <[email protected]>
Add Acceptance tests for `issue` command
…ancy IsEnterprise currently returns `true` when `IsTenancy` returns true. We prefer that this behavior is orthogonal. This commit adds failing tests to the instances where IsEnterprise should not behave the same as IsTenancy. These test cases are expected to pass with the inclusion of the coming improvements to go-gh to handle the orthogonality of IsEnterprise and IsTenancy.
…sult-handling Simplify Sigstore verification result handling in `gh attestation verify`
Signed-off-by: Meredith Lancaster <[email protected]>
Signed-off-by: Meredith Lancaster <[email protected]>
…eturn-when-no-caches-exist-instead-of-text-message Print empty array for `gh cache list` when `--json` is provided
…s/attest-build-provenance-1.4.4 Bump actions/attest-build-provenance from 1.4.3 to 1.4.4
Create the automatic key when specified with -i
fix: `gh pr create -w` ignore template flag
This commit expands upon the previous work by creating tests around extension command execution and how various extension update scenarios are handled. Along the way, the logic handling formatting update messaging has been switched to use `ColorScheme` in order to honor color behavior flags.
Check extension for latest version when executed
derockspace
had a problem deploying
to
production
November 14, 2024 02:20
— with
GitHub Actions
Failure
derockspace
had a problem deploying
to
production
November 14, 2024 02:20
— with
GitHub Actions
Failure
derockspace
merged commit Nov 17, 2024
7c5fc26
into
wm/extension-signal-handling
13 of 15 checks passed
derockspace
commented
Nov 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEROCK SPACE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<pThank you for contributing to GitHub CLI!>
<bTo reference an open issue, please write this in your description: `Fixes #NUMBER>