Chore/sc 117667/upgrade node version for dp produc #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeBiddell
changed the title
chroder
requested changes
Aug 28, 2024
| @@ -5,4 +5,4 @@ docker-product-base: | |||
| FROM DOCKERFILE -f ./Dockerfile ./ | |||
| ARG EARTHLY_TARGET_TAG_DOCKER | |||
| ARG IMAGE_TAG=$EARTHLY_TARGET_TAG_DOCKER | |||
| SAVE IMAGE --cache-from deskpro/docker-product-base:main deskpro/docker-product-base:$IMAGE_TAG | |||
| SAVE IMAGE --cache-from deskpro/docker-product-base:chore/sc-117667/upgrade-node-version-for-dp-product-jake deskpro/docker-product-base:$IMAGE_TAG | |||
There was a problem hiding this comment.
Don't do this; after merge this won't be correct. Keep it as :main
| @@ -56,6 +56,10 @@ else | |||
| fi | |||
|
|
|||
| main() { | |||
| # store the fact that we're running the entrypoint | |||
There was a problem hiding this comment.
There's already a sentinel file for a similar purpose at /run/container-ready that is-ready already checks. Does it not work as intended?
I would not think it's super useful to know if entrypoint specifically is running or not. It's more useful to know that services are actually running, which is the purpose of that sentinel file.
JakeBiddell
force-pushed
the
chore/sc-117667/upgrade-node-version-for-dp-product-jake
branch
from
271402f to
cf4a15e
Compare
JakeBiddell
force-pushed
the
chore/sc-117667/upgrade-node-version-for-dp-product-jake
branch
from
cf4a15e to
4942e38
Compare
JakeBiddell
force-pushed
the
chore/sc-117667/upgrade-node-version-for-dp-product-jake
branch
from
4942e38 to
b0d20ab
Compare
Add is-ready check on the default files tests Add a check the entrypoint is not still running (slightly different case to the ready file that gets added on first boot)
JakeBiddell
force-pushed
the
chore/sc-117667/upgrade-node-version-for-dp-product-jake
branch
from
b0d20ab to
beb7a65
Compare
JakeBiddell
force-pushed
the
chore/sc-117667/upgrade-node-version-for-dp-product-jake
branch
from
beb7a65 to
5c3a065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.