Add storybook to github pages to travis

deskpro · Oct 7, 2019 · 568ae27 · 568ae27
1 parent 54ccac3
commit 568ae27
Show file tree

Hide file tree

Showing 7 changed files with 31 additions and 24 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -9,8 +9,15 @@ branches:
   only:
   - master
 deploy:
-  provider: npm
-  api_key: '${NPM_TOKEN}'
-  skip_cleanup: true
-  on:
-    tags: true
+  - provider: npm
+    email: '[email protected]'
+    api_key: '${NPM_TOKEN}'
+    skip_cleanup: true
+    on:
+      tags: true
+  - provider: script
+    skip_cleanup: true
+    script:
+      - lerna run --scope @deskpro/content-editor-storybook deploy-storybook -- -- --ci
+    on:
+      branch: master
diff --git a/src/components/picker/nimble-picker.js b/src/components/picker/nimble-picker.js
@@ -81,13 +81,13 @@ export default class NimblePicker extends React.PureComponent {
         continue
       }
 
-      if (props.emojisToShowFilter) {
+      if (props.iconsToShowFilter) {
         let newEmojis = []
 
         const { icons } = category
         for (let emojiIndex = 0; emojiIndex < icons.length; emojiIndex++) {
           const emoji = icons[emojiIndex]
-          if (props.emojisToShowFilter(this.data.emojis[emoji] || emoji)) {
+          if (props.iconsToShowFilter(this.data.emojis[emoji] || emoji)) {
             newEmojis.push(emoji)
           }
         }
@@ -452,7 +452,7 @@ export default class NimblePicker extends React.PureComponent {
         color,
         native,
         backgroundImageFn,
-        emojisToShowFilter,
+        iconsToShowFilter,
         showPreview,
         showColorPicker,
         emojiTooltip,
@@ -491,7 +491,7 @@ export default class NimblePicker extends React.PureComponent {
           onSearch={this.handleSearch}
           data={this.data}
           i18n={this.i18n}
-          emojisToShowFilter={emojisToShowFilter}
+          iconsToShowFilter={iconsToShowFilter}
           include={include}
           exclude={exclude}
           custom={this.CUSTOM_CATEGORY.emojis}

diff --git a/src/components/search.js b/src/components/search.js
@@ -48,7 +48,7 @@ export default class Search extends React.PureComponent {
 
     this.props.onSearch(
       this.iconIndex.search(value, {
-        emojisToShowFilter: this.props.emojisToShowFilter,
+        iconsToShowFilter: this.props.iconsToShowFilter,
         maxResults: this.props.maxResults,
         include: this.props.include,
         exclude: this.props.exclude,
@@ -117,13 +117,13 @@ export default class Search extends React.PureComponent {
 Search.propTypes /* remove-proptypes */ = {
   onSearch: PropTypes.func,
   maxResults: PropTypes.number,
-  emojisToShowFilter: PropTypes.func,
+  iconsToShowFilter: PropTypes.func,
   autoFocus: PropTypes.bool,
 }
 
 Search.defaultProps = {
   onSearch: () => {},
   maxResults: 75,
-  emojisToShowFilter: null,
+  iconsToShowFilter: null,
   autoFocus: false,
 }
diff --git a/src/utils/icon-index/__tests__/emoji-index.test.js b/src/utils/icon-index/__tests__/emoji-index.test.js
@@ -1,29 +1,29 @@
-import emojiIndex from '../icon-index.js'
+import iconIndex from '../icon-index.js'
 
 test('should work', () => {
-  expect(emojiIndex.search('wheelchair')).toEqual([
+  expect(iconIndex.search('wheelchair')).toEqual([
     'accessible-icon',
     'crutch',
     'wheelchair',
   ])
 })
 
-test('should filter only emojis we care about, exclude pineapple', () => {
-  let emojisToShowFilter = (data) => {
+test('should filter only icons we care about, exclude pineapple', () => {
+  let iconsToShowFilter = (data) => {
     data !== 'deskpro'
   }
-  expect(emojiIndex.search('desk', { emojisToShowFilter })).not.toContain(
+  expect(iconIndex.search('desk', { iconsToShowFilter })).not.toContain(
     'deskpro',
   )
 })
 
 test('can search for thinking_face', () => {
-  expect(emojiIndex.search('fort awesome')).toEqual([
+  expect(iconIndex.search('fort awesome')).toEqual([
     'fort-awesome',
     'fort-awesome-alt',
   ])
 })
 
 test('can search for smile-beam', () => {
-  expect(emojiIndex.search('deskp')).toEqual(['deskpro'])
+  expect(iconIndex.search('deskp')).toEqual(['deskpro'])
 })
diff --git a/src/utils/icon-index/nimble-icon-index.js b/src/utils/icon-index/nimble-icon-index.js
@@ -51,7 +51,7 @@ export default class NimbleIconIndex {
 
   search(
     value,
-    { emojisToShowFilter, maxResults, include, exclude, custom = [] } = {},
+    { iconsToShowFilter, maxResults, include, exclude, custom = [] } = {},
   ) {
     maxResults || (maxResults = 75)
     include || (include = [])
@@ -169,9 +169,9 @@ export default class NimbleIconIndex {
     }
 
     if (results) {
-      if (emojisToShowFilter) {
+      if (iconsToShowFilter) {
         results = results.filter((result) =>
-          emojisToShowFilter(pool[result.id]),
+          iconsToShowFilter(pool[result.id]),
         )
       }
 

diff --git a/src/utils/shared-default-props.js b/src/utils/shared-default-props.js
@@ -28,7 +28,7 @@ const PickerDefaultProps = {
   native: EmojiDefaultProps.native,
   sheetSize: EmojiDefaultProps.sheetSize,
   backgroundImageFn: EmojiDefaultProps.backgroundImageFn,
-  emojisToShowFilter: null,
+  iconsToShowFilter: null,
   showPreview: true,
   showColorPicker: true,
   emojiTooltip: EmojiDefaultProps.tooltip,

diff --git a/src/utils/shared-props.js b/src/utils/shared-props.js
@@ -42,7 +42,7 @@ const PickerPropTypes = {
   native: PropTypes.bool,
   backgroundImageFn: EmojiPropTypes.backgroundImageFn,
   sheetSize: EmojiPropTypes.sheetSize,
-  emojisToShowFilter: PropTypes.func,
+  iconsToShowFilter: PropTypes.func,
   showPreview: PropTypes.bool,
   showColorPicker: PropTypes.bool,
   emojiTooltip: EmojiPropTypes.tooltip,