Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smlisk0630 first contribution #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add smlisk0630 first contribution #7

wants to merge 3 commits into from

Conversation

smlisk0630
Copy link

@smlisk0630 smlisk0630 commented Nov 17, 2022 •
edited
Loading

📖 How does it feel to contribute to open source?

It feels pretty cool!

💡 What did you learn?

  • I learned about draft PRs

👍 What worked well in this session?

  • The demo went well.

📈 How could we improve this session?

  • Written instructions provided for review ahead of the presentation would be helpful.

@smlisk0630 smlisk0630 marked this pull request as ready for review November 17, 2022 19:48
steveward
steveward approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@steveward steveward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveward steveward steveward approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smlisk0630 @steveward