Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for REG_EXPAND_SZ type #275

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Add support for REG_EXPAND_SZ type #275

merged 3 commits into from
Mar 5, 2024

Conversation

sergiou87
Copy link
Member

@sergiou87 sergiou87 commented Mar 1, 2024

In order to implement desktop/desktop#18244, support for writing REG_EXPAND_SZ values was needed.

After some investigation, it looks like it's just a string value that might contain expandable variables, so I have reused the logic to set REG_SZ values.

@sergiou87 sergiou87 marked this pull request as draft March 1, 2024 16:47
@sergiou87 sergiou87 marked this pull request as ready for review March 5, 2024 11:45
@sergiou87 sergiou87 requested a review from tidy-dev March 5, 2024 11:45
Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfamiliar syntax to me, but appears to to do as you say and replicate the logic from REG_SZ.

@sergiou87 sergiou87 merged commit 8183fca into master Mar 5, 2024
2 checks passed
@sergiou87 sergiou87 deleted the support-expand-sz branch March 5, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants