Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor issues to speed up block processing logic #565

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

diamondhands0
Copy link
Member

@diamondhands0 diamondhands0 commented Mar 25, 2024

  • The Dockerfile change in this PR switches us to compiling with debug
    settings. This slows things down a bit but it's worth it because it
    means we can attach debugging instances directly to a running node
    remotely.

  • Otherwise, this is just extra logging.

@diamondhands0 diamondhands0 requested a review from a team as a code owner March 25, 2024 02:23
# build backend
RUN GOOS=linux go build -mod=mod -a -installsuffix cgo -o bin/backend main.go
#RUN GOOS=linux go build -mod=mod -a -installsuffix cgo -o bin/backend main.go
RUN GOOS=linux go build -gcflags="all=-N -l" -mod=mod -a -installsuffix cgo -o bin/backend main.go
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We are choosing to do unoptimized builds here. I recommend that we keep this setting though because it allows us to super easily debug things and it didn't seem to slow things down that much. Maybe we can keep it until we have real issues.

@diamondhands0 diamondhands0 force-pushed the diamondhands/INCREASE-LOGGING-ON-BLOCK-TIP-ERROR branch from c965c77 to 972803e Compare March 25, 2024 03:01
* The Dockerfile change in this PR switches us to compiling with debug
  settings. This slows things down a bit but it's worth it because it
means we can attach debugging instances directly to a running node
remotely.

* Otherwise, this is just extra logging.
@diamondhands0 diamondhands0 force-pushed the diamondhands/INCREASE-LOGGING-ON-BLOCK-TIP-ERROR branch from 972803e to d0b70ee Compare March 25, 2024 03:03
@lazynina lazynina merged commit 90470bb into main Mar 29, 2024
2 checks passed
@lazynina lazynina deleted the diamondhands/INCREASE-LOGGING-ON-BLOCK-TIP-ERROR branch March 29, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants