Add ability to submit signatures without embedding them into txns #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…diamondhands/SIMPLIFY-SUBMIT-TRANSACTION-FLOW
lazynina
approved these changes
Jan 15, 2025
routes/transaction.go
Outdated
| if requestData.UnsignedTransactionHex != "" { | ||
| if requestData.TransactionSignatureHex == "" { | ||
| _AddBadRequestError(ww, fmt.Sprintf("SubmitTransactionRequest: "+ | ||
| "Must provide TransactionSignature when submitting UnsignedTransactionHex.")) |
There was a problem hiding this comment.
Suggested change
| "Must provide TransactionSignature when submitting UnsignedTransactionHex.")) | |
| "Must provide TransactionSignatureHex when submitting UnsignedTransactionHex.")) |
Just adding Hex for clarity. If a developer receives this error, it'll be more clear what the param should be in the request body.
routes/transaction.go
Outdated
| if len(requestData.UnsignedInnerTransactionsHex) > 0 && | ||
| len(requestData.UnsignedInnerTransactionsHex) != len(requestData.TransactionSignaturesHex) { | ||
| _AddBadRequestError(ww, fmt.Sprintf("SubmitAtomicTransaction: "+ | ||
| "Number of UnsignedInnerTransactionsHex must match number of TransactionSignatures.")) |
There was a problem hiding this comment.
Suggested change
| "Number of UnsignedInnerTransactionsHex must match number of TransactionSignatures.")) | |
| "Number of UnsignedInnerTransactionsHex must match number of TransactionSignaturesHex.")) |
diamondhands0
deleted the
diamondhands/SIMPLIFY-SUBMIT-TRANSACTION-FLOW
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm updating the Openfund docs and working on a tutorial to enable algorithmic trading, and this change makes it possible to trivially sign transactions in languages that we don't support, such as Python, which I was using for the tutorial (most commonly used by traders).
This code is now fully tested by the amm-service, which I adapted to use the alternative pathways in a couple of tests. See this PR here:
https://github.com/deso-protocol/amm-service/pull/15