Skip to content

Commit

Permalink
clean up comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lazynina committed Dec 12, 2024
1 parent a8384cb commit 8aa423e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions lib/blockchain.go
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,7 @@ func NewBlockIndex(db *badger.DB, snapshot *Snapshot, tipNode *BlockNode) *Block
snapshot: snapshot,
blockIndexByHash: blockIndexByHash,
tip: tipNode,
headerTip: tipNode,
}
}

Expand Down
3 changes: 0 additions & 3 deletions lib/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -1126,9 +1126,6 @@ func (srv *Server) shouldVerifySignatures(header *MsgDeSoHeader, isHeaderChain b
if checkpointBlockInfo == nil {
return true, false
}
// TODO: @diamondhands - why can't we move this up in this function? It seems like we can avoid
// checking if we have the checkpoint block node if the header we're processing is below the height.
// This will save us 17-18% of the time it takes to process headers.
// If the current header has a height below the checkpoint block height, we should skip signature verification
// even if we've seen the checkpoint block hash.
if header.Height < checkpointBlockInfo.Height {
Expand Down

0 comments on commit 8aa423e

Please sign in to comment.