Merge pull request #32 from deso-protocol/bump-derived-key-expiration

Update expiration block height computation
deso-protocol · Feb 14, 2024 · d4723fd · d4723fd
2 parents e3dabc4 + ea675d8
commit d4723fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/identity/derived-key-utils.ts b/src/identity/derived-key-utils.ts
@@ -23,9 +23,9 @@ export async function generateDerivedKeyPayload(
 ) {
   const { BlockHeight } = await getAppState();
 
-  // days * (24 hours / day) * (60 minutes / hour) * (1 block / 5 minutes) = blocks
+  // days * (24 hours / day) * (60 minutes / hour) * (60 seconds / minute) * (1 block / 1 second) = blocks
   const expirationBlockHeight =
-    BlockHeight + (numDaysBeforeExpiration * 24 * 60) / 5;
+    BlockHeight + numDaysBeforeExpiration * 24 * 60 * 60;
   const ownerPublicKeyBase58 = publicKeyToBase58Check(ownerKeys.public, {
     network,
   });

diff --git a/src/identity/identity.spec.ts b/src/identity/identity.spec.ts
@@ -1008,7 +1008,7 @@ describe('identity', () => {
   });
   describe('loginWithAutoDerive()', () => {
     it('it stores the expected derive data when generating a local derived key payload', async () => {
-      const expectedExpirationBlock = 1294652;
+      const expectedExpirationBlock = 315603452;
       const expectedDerivePayload = {
         derivedPublicKeyBase58Check:
           'BC1YLhKdgXgrZ1XkCzbmP6T9bumth2DgPwNjMksCAXe5kGU9LnxQtsX',