Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DES-178: add youtube shorts embed support #316

Merged
merged 2 commits into from
Sep 6, 2023
Merged

DES-178: add youtube shorts embed support #316

merged 2 commits into from
Sep 6, 2023

Conversation

vyneer
Copy link
Contributor

@vyneer vyneer commented Sep 4, 2023

Adds support for embedding YouTube shorts.

Before:
image

After:
image

@vyneer vyneer added the enhancement New feature or request label Sep 4, 2023
@vyneer vyneer requested a review from 11k September 4, 2023 10:23
11k
11k approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this would require some changes to the Bigscreen page embed regex, too. Good to see it just works!

@11k 11k merged commit fcec616 into destinygg:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@11k 11k 11k approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyneer @11k