Remove mention button from userlist #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11k
requested changes
Oct 14, 2024
There was a problem hiding this comment.
I think the primary motivation for this was to improve chat performance, correct? After all our troubleshooting, it's abundantly clear that unintended repaints due to emote CSS animations is causing the performance issues, so I think this change has negligible impact.
We can take this opportunity to reassess the value of this feature though. I think there's utility in a new user being able to click a button to whisper a moderator. This is the same behavior Twitch offers in its user list. I don't think there's nearly as much utility in having a reply button, however.
Let's instead rework this PR to remove the reply button only.
Mitchdev
changed the title
Mitchdev
changed the title
11k
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.