Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move history to chat #518

Merged
merged 9 commits into from
Nov 17, 2024
Merged

Move history to chat #518

merged 9 commits into from
Nov 17, 2024

Conversation

Mitchdev
Copy link
Contributor

@Mitchdev Mitchdev commented Aug 22, 2024 •
edited
Loading

One minor issue which I will fix in a separate PR;

  • When a message in history was sent by you it still loads as the already rendered message has a different timestamp to the server which alters the md5. Fixing this will also fix the emote altercation sync issue.

https://github.com/destinygg/website-private/pull/434
https://github.com/destinygg/chat-private/pull/62

@Mitchdev Mitchdev added the enhancement New feature or request label Aug 22, 2024
@Mitchdev Mitchdev requested a review from 11k August 22, 2024 10:40
@11k 11k merged commit 89ef5d1 into master Nov 17, 2024
2 checks passed
@11k 11k deleted the history-to-chat branch November 17, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@11k 11k 11k approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mitchdev @11k