Added hotkey for ESC key to scroll chat to bottom #547
Conversation
Voiture-0
force-pushed
the
feature/escape-pins-chat
branch
from
bf62375 to
44355fc
Compare
There was a problem hiding this comment.
Would you mind merging in master and making it so that if an event bar event is selected, ESC would unselect it? This can occur after the menu check, but before the pinned check.
Also, I'd like you to remove the comments and switch to if statements that aren't single-line/braceless.
assets/chat/js/chat.js
Outdated
| @@ -415,7 +415,13 @@ class Chat { | |||
|
|
|||
| // ESC | |||
| document.addEventListener('keydown', (e) => { | |||
| if (isKeyCode(e, KEYCODES.ESC)) ChatMenu.closeMenus(this); // ESC key | |||
| if (isKeyCode(e, KEYCODES.ESC)) { | |||
| const activeView = this.getActiveWindow().scrollplugin; | |||
There was a problem hiding this comment.
You can go ahead and add a method to ChatWindow that scrolls it to the bottom so you don't have to interface with its scroll plugin directly.
There was a problem hiding this comment.
Good idea! Added methods on ChatWindow to interface with its scroll plugin
Updated! I also added clearing the user focus as well, as the lowest priority check. Let me know if you think that is okay or if I should removed that part entirely. |
This update introduces a hotkey function similar to Discord's. When the chat window is scrolled up, pressing
ESCwill bring the view back to the latest messages.In DGG, if the chat is not already pinned to the bottom, pressing
ESCwill scroll it down. However, if any menus are open (e.g., emote or settings),ESCwill first close those menus instead of scrolling. Scrolling will only occur when there are no other actions forESCto perform.