-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DGGTweaker Features - Link Hitbox Scaling, RustleSearch button and Lucide Icons #553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For your link scaling setting, (1) the way it's presented in the settings menu is confusing to the average user, (2) there's too much flexibility in allowing a custom multiplier considering only a few values are actually sane, and (3) the scaling seems to apply upward more than it does downward.
We can work to address these issues, but I don't think it's worth it because difficulty with clicking links isn't a big problem. The setting works perfectly as a customization for interested users to apply via an extension like yours.
Other than that, would you mind updating the embed link icon to Lucide as well? It's the TV that's displayed alongside an embeddable URL and is defined inline in UrlFormatter.js
.
I've reverted the link hitbox changes, changed the embed icon and addressed other mentioned changes. |
After Cake mentioned it in the discord I figured I'd port the chat related stuff from my extension to the main chat codebase.
Here's a list of the changes: