Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DGGTweaker Features - Link Hitbox Scaling, RustleSearch button and Lucide Icons #553

Merged
merged 14 commits into from
Nov 16, 2024

Conversation

AlexDavies8
Copy link
Contributor

After Cake mentioned it in the discord I figured I'd port the chat related stuff from my extension to the main chat codebase.
Here's a list of the changes:

  • Added a new chat setting to increase the clickable area of a link (bigger 'hitbox')
  • Added button to the user info right click menu that directly links to rustlesearch.dev
  • Basic support for numeric fields in chat settings (in the future could put maxlines in the UI instead of needing a command)
  • Icons have been swapped out for Lucide icons to match with the main site redesign
  • Button tooltips have been changed from using the title attribute to using tippy, and the tippy style is prettier

New Look

Copy link
Contributor

@11k 11k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For your link scaling setting, (1) the way it's presented in the settings menu is confusing to the average user, (2) there's too much flexibility in allowing a custom multiplier considering only a few values are actually sane, and (3) the scaling seems to apply upward more than it does downward.

We can work to address these issues, but I don't think it's worth it because difficulty with clicking links isn't a big problem. The setting works perfectly as a customization for interested users to apply via an extension like yours.

Other than that, would you mind updating the embed link icon to Lucide as well? It's the TV that's displayed alongside an embeddable URL and is defined inline in UrlFormatter.js.

assets/chat/js/menus/ChatUserMenu.js Outdated Show resolved Hide resolved
assets/chat/img/icon-open-in-new.svg Outdated Show resolved Hide resolved
assets/chat/img/icon-favorite-fill.svg Outdated Show resolved Hide resolved
@AlexDavies8
Copy link
Contributor Author

I've reverted the link hitbox changes, changed the embed icon and addressed other mentioned changes.

@AlexDavies8 AlexDavies8 requested a review from 11k November 14, 2024 23:19
@11k 11k merged commit 1e16139 into destinygg:master Nov 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants