Fix error when publishing new version #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent PR modified the `prepare` script to use `shx` for Windows interoperability. The `prepare` script is special in that npm always runs it before `npm publish`. This resulted in an error during the execution of our "bump and release" workflow because the workflow doesn't install any Node dependencies. Simply installing Node dependencies in the workflow fixes the issue. This has the added benefit of catching any last-second formatting or linter errors that slipped through the cracks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent PR modified the
preparescript to useshxfor Windows interoperability. Thepreparescript is special in that npm always runs it beforenpm publish. This resulted in an error during the execution of our "bump and release" workflow because the workflow doesn't install any Node dependencies.Simply installing Node dependencies in the workflow fixes the issue. This has the added benefit of catching any last-second formatting or linter errors that slipped through the cracks.