Fix issue with duplicate messages on reconnect #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unresolved message has a hash that differs from its counterpart in chat history as tracked by the server. This is because a message's timestamp is used to generate its hash and client-side and server-side timestamps differ. The system for preventing duplicate messages when processing the chat history payload uses message hashes to determine if a message already exists. As a result, if the user disconnects and reconnects, their recent messages will be rendered to the DOM a second time. Modifying the message resolution system to update the timestamp of a user's message after it's echoed by the server fixes the issue. After resolution, a message's client-side timestamp will match its server-side timestamp, as will its hash.
Only generating the hash for a message in the `ChatMessage` constructor doesn't consider the fact that a message's user is often set in a child class' contructor. A message's hash is derived from the user's ID, so its hash also needs to be regenerated in this circumstance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.