Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check duplicate event and death messages #584

Closed
wants to merge 4 commits into from

Conversation

vyneer
Copy link
Contributor

@vyneer vyneer commented Dec 2, 2024

closes #576

@vyneer vyneer added the bug Something isn't working label Dec 2, 2024
@vyneer vyneer requested review from Mitchdev and 11k December 2, 2024 14:48
Copy link
Contributor

@Mitchdev Mitchdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thinking adding containsMessage to addMessage is an easier fix instead of adding it to every onTYPE

addMessage(message, win = null) {

@Mitchdev
Copy link
Contributor

#594

@Mitchdev Mitchdev closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The system for not adding duplicate messages to the DOM only works for user messages
2 participants