Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure there is at least 150 history messages in the message array. #588

Closed
wants to merge 3 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 6 additions & 11 deletions assets/chat/js/chat.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
ChatMessage,
ChatUserMessage, // eslint-disable-line no-unused-vars
checkIfPinWasDismissed,
clientOnlyMessages,
} from './messages';
import {
ChatMenu,
Expand Down Expand Up @@ -827,12 +828,7 @@ class Chat {

// Hide the message if the user is ignored
if (
![
MessageTypes.UI,
MessageTypes.INFO,
MessageTypes.ERROR,
MessageTypes.STATUS,
].includes(message.type) &&
!clientOnlyMessages.includes(message.type) &&
this.ignored(message.user?.username, message.message)
) {
message.ignore();
Expand Down Expand Up @@ -1467,16 +1463,15 @@ class Chat {
}

onADDPHRASE(data) {
MessageBuilder.command(`Phrase "${data.data}" added.`, data.timestamp).into(
MessageBuilder.info(`Phrase "${data.data}" added.`, data.timestamp).into(
this,
);
}

onREMOVEPHRASE(data) {
MessageBuilder.command(
`Phrase "${data.data}" removed.`,
data.timestamp,
).into(this);
MessageBuilder.info(`Phrase "${data.data}" removed.`, data.timestamp).into(
this,
);
}

onPRIVMSGSENT() {
Expand Down
13 changes: 12 additions & 1 deletion assets/chat/js/messages/MessageTypes.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default {
const MessageTypes = {
STATUS: 'STATUS',
ERROR: 'ERROR',
INFO: 'INFO',
Expand All @@ -15,3 +15,14 @@ export default {
DONATION: 'DONATION',
DEATH: 'DEATH',
};

const clientOnlyMessages = [
MessageTypes.STATUS,
MessageTypes.ERROR,
MessageTypes.INFO,
MessageTypes.UI,
];

export default MessageTypes;

export { clientOnlyMessages };
2 changes: 1 addition & 1 deletion assets/chat/js/messages/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export { default as MessageBuilder } from './MessageBuilder';
export { default as MessageTypes } from './MessageTypes';
export { default as MessageTypes, clientOnlyMessages } from './MessageTypes';
export { default as ChatMessage } from './ChatMessage';
export { default as ChatDonationMessage } from './ChatDonationMessage';
export { default as ChatEmoteMessage } from './ChatEmoteMessage';
Expand Down
32 changes: 21 additions & 11 deletions assets/chat/js/window.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import $ from 'jquery';
import { throttle } from 'throttle-debounce';
import ChatScrollPlugin from './scroll';
import EventEmitter from './emitter';
import { MessageTypes } from './messages';
import { clientOnlyMessages, MessageTypes } from './messages';

const tagcolors = [
'green',
Expand Down Expand Up @@ -122,9 +122,26 @@ class ChatWindow extends EventEmitter {
remove.forEach((element) => {
element.remove();
});

this.messages = this.messages.slice(lines.length - this.maxlines);
}

let clientMessages = 0;
this.messages = this.messages
.reverse()
.filter((message, index) => {
if (clientOnlyMessages.includes(message.type)) {
clientMessages += 1;
// remove client only messages if above maxlines
if (index >= this.maxlines) {
return false;
}
// remove history message if above maxlines/maxhistory + the clientMessages
} else if (index >= Math.max(this.maxlines, 150) + clientMessages) {
return false;
}

return true;
})
.reverse();
}
}

Expand Down Expand Up @@ -152,14 +169,7 @@ class ChatWindow extends EventEmitter {

const username = message.user?.username;

if (
![
MessageTypes.UI,
MessageTypes.INFO,
MessageTypes.ERROR,
MessageTypes.STATUS,
].includes(message.type)
) {
if (!clientOnlyMessages.includes(message.type)) {
message.ignore(chat.ignored(username, message.message));
}

Expand Down
Loading