#98 Allow for descriminate-types options and other typechain flags #99
Conversation
ShravanSunder
commented
May 13, 2022
•
ShravanSunder
commented
- Allow for descriminate-types options and other typechain flags #98
# Conflicts: # packages/eth-sdk/src/client/generateTsClient.ts # packages/eth-sdk/src/client/generateTypes.ts
🦋 Changeset detectedLatest commit: 8a74669 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
# Conflicts: # packages/eth-sdk/src/client/generateTsClient.ts # packages/eth-sdk/src/client/generateTypes.ts
|
cc: @krzkaczor |
ShravanSunder
changed the title
| @@ -19,7 +20,17 @@ export async function generateSdk(ctx: EthSdkCtx): Promise<void> { | |||
| const outputToAbiRelativePath = relative(outputPath, abisRoot).replace(/\\/g, '/') | |||
|
|
|||
| const randomTmpDir = await fs.tmpDir('eth-sdk') | |||
| await generateTsClient(contracts, abisRoot, randomTmpDir, outputToAbiRelativePath, fs) | |||
|
|
|||
| const shapedFlag: CodegenConfig = { | |||
There was a problem hiding this comment.
I don't like that we provide defaults for the second time here. Could you make a PR to TypeChain that would export DEFAULT_FLAGS? Then we could simply use them here and add only user provided flags
|
@krzkaczor i'm unable to develop typechain due to pnpm issues, maybe we can mere this as is and make another PR for the default flags? I'll push change to the name of the flag |
|
@krzkaczor made the change you suggested, if possible lets do the default change in a seperate PR? :) |
|
@ShravanSunder yes we can merge this but build failed. Can you take a look. And please pull before fixing it because I pushed changeset fix. |
|
@krzkaczor fixed! 🙏🏽 |
