Last-minute CI fixes on Travis #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bast
force-pushed
the
streamline-travis
branch
from
f6da84a to
dd508af
Compare
robertodr
force-pushed
the
streamline-travis
branch
from
b91fc3b to
45247b4
Compare
CMake aborts if no ELF patching tool is found, rather than sending an empty string to Python.
This is done by: - Invalidating PYENV_ROOT - Exporting a PYTHON3 variable depending on the platform
- this does not require canonicalize_filename.sh - custom.sh does not need to be copied but can itself be symlinked
CMake fixes the RPATH for us, so: 0. Remove the whole shenanigans with removing the build RPATH and adding the install RPATH. It's already done. 1. We still search for the various tools, but now only have them print the RPATH. 2. The install SCRIPT runs the installed use_message. Just to make sure everything went well.
this is to avoid that the build tries to tar itself which can lead to "file changed as we read it"
Boost Python version installed from APT still links against Python 2.7, whereas we need 3.5
robertodr
force-pushed
the
streamline-travis
branch
from
45247b4 to
6210caf
Compare
robertodr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I had nothing better to do for the last call before the bar closes, I decided to kick up the can of worms of CI on Travis.
requirements.txtPipfileStatus