sshd_config syntax guard is missing on PermitTunnel #845
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a value for
ssh_permit_tunnel
is passed to thedevsec.hardening.ssh_hardening
role, then at present that value is passed on without validation.This is because the value of
ssh_permit_tunnel
is not guarded inopensshd.conf.j2
:this stands in contrast to other boolean values which have appropriate guards to ensure valid syntax:
e,g,
This PR resolves this issue and ensures that PermitTunnel will render correctly