Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed feature for .net aspire #1257

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

danmoseley
Copy link

@danmoseley danmoseley commented Feb 1, 2025

Prior art published from their own repos --
".NET Aspire" https://github.com/NikiforovAll/devcontainer-features
".NET Aspire Daily Builds" https://github.com/ElanHasson/devcontainer-features
Thank you @NikiforovAll and @ElanHasson for publishing these!

These happen to be at the top of the list:
image

Both of these use the old way to install .NET Aspire, based on "dotnet workload". This only works with Aspire 8.0. From Aspire 9.0 onwards, this is no longer relevant. Anyone using Aspire today will likely want 9.0 or later.

I considered offering PR's to update each of them, but it seems to me that it would be better to have a single devcontainer feature for .NET Aspire which handled both scenarios plus arbitrary versions (>=9.0). This is that.

Merging this would require that the existing features be unpublished when this was merged, or this uses a different name. @NikiforovAll and @ElanHasson what would you think of replacing yours with a combined one?

cc @joperezr @davidfowl

When merged it could replace this line in the Aspire repo

@danmoseley danmoseley requested a review from a team as a code owner February 1, 2025 02:52
@danmoseley
Copy link
Author

cc @joshspicer as he wrote the dotnet one (thanks)

@ElanHasson
Copy link

ElanHasson commented Feb 1, 2025

Hey @danmoseley!

I'm cool with that, hopefully it'll be an official feature 😎

Let me know what you'd like me to do and when.

@danmoseley
Copy link
Author

tests pass locally; ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants