-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed feature for .net aspire #1257
Open
danmoseley
wants to merge
12
commits into
devcontainers:main
Choose a base branch
from
danmoseley:dotnetaspire1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @joshspicer as he wrote the dotnet one (thanks) |
Hey @danmoseley! I'm cool with that, hopefully it'll be an official feature 😎 Let me know what you'd like me to do and when. |
tests pass locally; ready for review. |
davidfowl
reviewed
Feb 1, 2025
davidfowl
reviewed
Feb 1, 2025
davidfowl
reviewed
Feb 1, 2025
danmoseley
force-pushed
the
dotnetaspire1
branch
from
February 1, 2025 05:40
fb55c4c
to
9dbe13a
Compare
danmoseley
force-pushed
the
dotnetaspire1
branch
from
February 1, 2025 06:02
0b69c2f
to
b7f6f8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior art published from their own repos --
".NET Aspire" https://github.com/NikiforovAll/devcontainer-features
".NET Aspire Daily Builds" https://github.com/ElanHasson/devcontainer-features
Thank you @NikiforovAll and @ElanHasson for publishing these!
These happen to be at the top of the list:
Both of these use the old way to install .NET Aspire, based on "dotnet workload". This only works with Aspire 8.0. From Aspire 9.0 onwards, this is no longer relevant. Anyone using Aspire today will likely want 9.0 or later.
I considered offering PR's to update each of them, but it seems to me that it would be better to have a single devcontainer feature for .NET Aspire which handled both scenarios plus arbitrary versions (>=9.0). This is that.
Merging this would require that the existing features be unpublished when this was merged, or this uses a different name. @NikiforovAll and @ElanHasson what would you think of replacing yours with a combined one?
cc @joperezr @davidfowl
When merged it could replace this line in the Aspire repo