Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RHEL support to go feature #846

Merged

Conversation

jdputschadi
Copy link
Contributor

@jdputschadi jdputschadi commented Feb 12, 2024

This PR adds RHEL support to the go feature.

CentOS 7, RHEL/Alma/Rocky Linux 8 & 9, Mariner, and Fedora should all work. Tests for all of these are included.

resolves #845

Jeff.

@jdputschadi jdputschadi requested a review from a team as a code owner February 12, 2024 23:53
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for another wonderful PR 👏

One minor (nit) comment, and we are all set!

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, again!! ✨

@samruddhikhandale samruddhikhandale merged commit 28b69c5 into devcontainers:main Feb 14, 2024
1 check passed
@jdputschadi jdputschadi deleted the go-feature-rhel-support branch February 14, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add RHEL support to go feature
2 participants