Add proposal and update schema #571
Open
+221
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
chrmarti
requested changes
May 5, 2025
|
|
||
| ## Proposed Solution | ||
|
|
||
| Extend the Dev Container Feature Options Schema by introducing `array` and `object` as valid types for feature options. These new types will enable developers to create more complex and customizable features. |
There was a problem hiding this comment.
What types of values would be supported? Maybe limiting it to strings and booleans would keep it simple and aligned with the existing types.
|
|
||
| # Install dependencies | ||
| echo "Installing dependencies..." | ||
| for package in "${DEPENDENCIES[@]}"; do |
There was a problem hiding this comment.
This seems to be Bash specific syntax. How would this work with the Bourne shell /bin/sh? The Bourne shell is used for the install scripts to allow for compatibility with distributions not including Bash by default like Alpine Linux.
Graysonbarton
approved these changes
May 6, 2025
Graysonbarton
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following provides a clear proposal for the inclusion of the array and object types for Feature options. The updated schema validate JSON Schema 7 via https://www.jsonschemavalidator.net/ and was tested against the samples provided in the proposal.