Add checks to ensure in-word formatting chars aren't replaced #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basic text formatting sequences (_, *, __, **) are now required to not be entirely within a word; that is, they must have a non-word character on either side to be replaced. This prevents words that include those characters (snake_case words, or some proper nouns that may include an Embedded*Asterisk__Or**Two for some reason) from being captured. Fixes developit#21
|
Yes it's expected in most markdown formatters that one single underscore inside a word should not be interpreted as the start of an italic sentence with no end. Could this PR be taken into consideration? |
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic text formatting sequences (_, *, __, **) are now required to not
be entirely within a word; that is, they must have a non-word character
on either side to be replaced.
This prevents words that include those characters (snake_case words, or
some proper nouns that may include an Embedded*Asterisk__Or**Two for
some reason) from being captured.
Fixes #21