Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge with stac-fastapi-pgstac settings and defaults to all extensions #24

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

vincentsarago
Copy link
Member

This PR does:

  • simplify the Settings class by using stac-fastapi-pgstac settings as base and extending it
  • remove the extensions settings (eoapi-devseed is a demo, we don't really need to make it configurable)

@vincentsarago vincentsarago requested a review from hrodmn February 6, 2025 21:42
response_class=ORJSONResponse,
),
"bulk_transactions": BulkTransactionExtension(client=BulkTransactionsClient()),
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed the transaction extensions because I assume we will:

  • either add the ingestor api
  • add them back once we have some auth defined

Copy link
Contributor

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates!

runtimes/eoapi/stac/eoapi/stac/config.py Outdated Show resolved Hide resolved
runtimes/eoapi/stac/eoapi/stac/app.py Show resolved Hide resolved
runtimes/eoapi/stac/eoapi/stac/config.py Show resolved Hide resolved
@vincentsarago vincentsarago merged commit 767c4d1 into main Feb 7, 2025
1 check passed
@vincentsarago vincentsarago deleted the feature/simplify-settings-and-extensions branch February 7, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants