Allow additional secrets to set environment variables #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/handle-secrets
branch
from
d4801cc to
3eece9a
Compare
pantierra
force-pushed
the
feature/handle-secrets
branch
from
3eece9a to
aab936a
Compare
|
The first approach wasn't working, so I introduced an |
pantierra
changed the title
pantierra
changed the title
pantierra
force-pushed
the
feature/handle-secrets
branch
from
aab936a to
c82541a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
envVarsfor eoapi allow setting of environment variables as a string. However these values might be set in some kubernetes secret. Let's extend eoAPI to handle those cases.