Review of webapp helm charts #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/some-more-helm-deployment
branch
3 times, most recently
from
d7a3eba to
20fb1b6
Compare
Co-authored-by: Ciaran Sweet <[email protected]>
pantierra
force-pushed
the
feature/some-more-helm-deployment
branch
from
20fb1b6 to
fea9f62
Compare
|
Is it worth us modifying the workflow that's failing to extract the version from the right place? |
|
Sure, next PR with the general |
ciaransweet
approved these changes
Oct 29, 2024
|
@pantierra make sure to align version in both python project file and CHarts.yaml to make tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the tutorial @emmanuelmathot is giving @ciaransweet and myself this PR introduces some adjustments to make the
basic webapp-polderwork.This PR is draft for now as it depends on #14 It will be rerolled after the first PR got in.