Added in environment variable for sorting/config #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Column order is important for a few of the tables I work with and switching my users from their (database-defined) order to alphabetical caused a little shellshock. Essentially, getting this functionality will be the last part of our migration from a different feature server package.
How it works
We add an environment variable
TIPG_SORT_COLUMNS(which defaults toTrue). Set it toFalseto disable sorting of columns. It's essentially trivial code, plus accompanying docs andSettingsmodel updates.Anything else?
Let me know if I need to add anything else here.