Use non-minified protomaps-leaflet@latest #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmcandr
changed the title
bmcandr
force-pushed
the
fix/protomaps-leaflet-source
branch
from
124e8af to
046fc9a
Compare
|
I've merged this but I will edit to pin a specific version which feels more thanks @bmcandr for the PR 🙏 |
|
Makes sense. I originally went with the link pinned to 4.0.1, but swapped it out after I realized the minified link was the issue. Apologies for the last second switcheroo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Swapped
https://unpkg.com/protomaps-leaflet@latest/dist/protomaps-leaflet.min.js->https://unpkg.com/protomaps-leaflet@latest/dist/protomaps-leaflet.jsinmap.htmltemplate.How I did it
Their docs does not link to a minified version so I tried that.
How you can test it
Test the viewer on
mainvs this branch.Related Issues
Closes #189