-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy documentation and document time series api limits #42
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
e4e6813
to
acc239f
Compare
7ea2bb8
to
abe6317
Compare
049c9a7
to
f709c65
Compare
f709c65
to
156f54a
Compare
📚 Documentation preview will be available at: https://developmentseed.github.io/titiler-cmr/pr-previews/pr-42/ Status: ✅ Preview is ready! |
e408669
to
e52d5b2
Compare
@hrodmn thanks for this, this guidance is super helpful. 2 questions:
|
Sure that makes sense to me - is that a convention for netcdf datasets? Most of my experience is with raster datasets so I usually think about cells as pixels.
I have only done a small amount of profiling in the Lambda context, but I think there are two ways large images can affect time series requests:
|
@hrodmn And thanks for the responses to question 2 - those reasons make sense to me. I don't think it's worth further investigation at this point and it's great that the individual image size limits are included in the documentation. |
This PR adds changes for a) deploying the documentation to GH pages, b) adds an API benchmarking process (and report in the docs) for the time series endpoints. After talking about it some more with the team I think we can be more surgical in the benchmark approach (i.e. predict limits based on Lambda configuration parameters), but the exercise was still helpful for understanding when things fall apart and which knobs you can turn to get time series requests that return a response before the Lambda breaks down. There are definitely some modifications or alternative approaches that are worth considering to improve the capabilities of this application!
A preview of the docs for this PR are available here: https://developmentseed.org/titiler-cmr/pr-previews/pr-42/
I'm not sure if I'll keep the PR preview feature alive since it is so easy to deploy the docs locally (
uv sync && uv run mkdocs serve -o
) but I'll leave it up for now so others can take a look at the rendered site.