WMTS BoundingBox fix and WMTS template adjustment #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if boundingbox element is used, as the coords must match the CRS order updates WMTS XML template to avoid placing extra new lines in various places
| @@ -51,13 +51,13 @@ | |||
| </TileMatrixSetLink> | |||
| <ResourceURL format="{{ media_type }}" resourceType="tile" template="{{ layer.tiles_url }}?{{ layer.query_string | escape }}" /> | |||
| </Layer> | |||
| {% endfor %} | |||
| {%- endfor %} | |||
There was a problem hiding this comment.
it removes extra white space that's being inserted https://jinja.palletsprojects.com/en/stable/templates/#whitespace-control
|
thanks @AndrewAnnex could you please add a note in https://github.com/developmentseed/titiler/blob/main/CHANGES.md#unreleased |
|
hmm I don't know why the black formatting check is failing, last commit I ran it locally and I just did again via the pre-commit but no changes occured (which I keep forgetting about installing on new systems I'm deving on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug where the WMTS BoundingBox coordinates flipped incorrectly if boundingbox element is used, as the coords must match the CRS order
updates WMTS XML template to avoid placing extra new lines in various places