Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create devfile for devfile registry deployments #1200

Closed
5 tasks done
michael-valdron opened this issue Jul 24, 2023 · 7 comments · Fixed by devfile/registry#256
Closed
5 tasks done

Create devfile for devfile registry deployments #1200

michael-valdron opened this issue Jul 24, 2023 · 7 comments · Fixed by devfile/registry#256
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure area/releng Release engineering

Comments

@michael-valdron
Copy link
Member

michael-valdron commented Jul 24, 2023

Which area this feature is related to?

/area registry
/area releng

Which functionality do you think we should add?

Why is this needed? Is your feature request related to a problem?

Create a devfile for making deployments of our devfile registries to devfile adopted platforms such as Red Hat Trusted Application Pipeline.

Detailed description:

Currently our community devfile registry is using a OpenShift template for deployment on our dedicated hosting environment. It would be great to have a outerloop devfile with resource deployment specs under the source repository to allow deployments using devfile consumers. In addition, this could also give more options of deployments to those wanting to deploy to their own Kubernetes or OpenShift environments.

Describe the solution you'd like

  • Create a devfile which defines the deployment layout for the devfile registry

  • Convert existing OpenShift template into compatible deployment spec which can be referenced by the devfile or independently used with other methods

  • Make any necessary modifications to scripts

  • Update documentation to describe these changes

  • Add tests for at least the existing platforms

Apply both tasks for the community devfile registry and the product devfile registry.

Describe alternatives you've considered

Alternatively, we can do one of the following:

  1. Use existing deployment template and handle other components using existing methods
  2. Convert the existing deployment template to be compatible with more deployment methods without a devfile
    1. Still needs to handle other components using existing methods

Additional context

@openshift-ci openshift-ci bot added area/registry Devfile registry for stacks and infrastructure area/releng Release engineering labels Jul 24, 2023
@michael-valdron michael-valdron moved this to Backlog in Devfile Project Jul 24, 2023
@feloy feloy moved this from Backlog to To Do 📝 in Devfile Project Sep 29, 2023
@feloy feloy moved this from To Do 📝 to Backlog in Devfile Project Oct 2, 2023
@jasperchui jasperchui moved this from Backlog to To Do 📝 in Devfile Project Oct 11, 2023
@michael-valdron michael-valdron moved this from To Do 📝 to Backlog in Devfile Project Oct 13, 2023
@michael-valdron michael-valdron moved this from Backlog to To Do 📝 in Devfile Project Nov 17, 2023
@michael-valdron
Copy link
Member Author

Changing priority to blocker as it is blocking changes in the deployment setup of the community devfile registry.

@michael-valdron michael-valdron moved this from To Do 📝 to In Progress 🚧 in Devfile Project Nov 29, 2023
@michael-valdron
Copy link
Member Author

Using inline for openshift components to inplace variables. Support for passing OpenShift template parameters in devfiles would simplify this step.

@michael-valdron
Copy link
Member Author

kubernetes components defines the deployment neutral resources and k8s ingress. openshift component continues to define OpenShift Route resource.

This will let us deploy to OpenShift and Kubernetes using common specs.

Using inline for openshift components to inplace variables.

Now using separated resources files with variable references.

@michael-valdron
Copy link
Member Author

Created odo v3 deployment check, currently investigating the following error message experienced with odo in GitHub workflow:

✗  failed to create service(s) associated with the component: Internal error occurred: failed calling webhook "validate.nginx.ingress.kubernetes.io": failed to call webhook: Post "[https://ingress-nginx-controller-admission.ingress-nginx.svc:443/networking/v1/ingresses?timeout=10s](https://ingress-nginx-controller-admission.ingress-nginx.svc/networking/v1/ingresses?timeout=10s)": dial tcp 10.106.217.105:443: connect: connection refused

@michael-valdron
Copy link
Member Author

Created odo v3 deployment check, currently investigating the following error message experienced with odo in GitHub workflow:

✗  failed to create service(s) associated with the component: Internal error occurred: failed calling webhook "validate.nginx.ingress.kubernetes.io": failed to call webhook: Post "[https://ingress-nginx-controller-admission.ingress-nginx.svc:443/networking/v1/ingresses?timeout=10s](https://ingress-nginx-controller-admission.ingress-nginx.svc/networking/v1/ingresses?timeout=10s)": dial tcp 10.106.217.105:443: connect: connection refused

Error was caused by the ingress controller not being ready before odo deploy was executed, this problem was solved by including the following before executing odo deploy to wait for the ingress controller to be ready:

kubectl wait pods -l app.kubernetes.io/name=ingress-nginx,app.kubernetes.io/component=controller --namespace ingress-nginx --for=condition=Ready --timeout=600s

@michael-valdron
Copy link
Member Author

Devfile confirmed compatiblity with odo v3 and ODC:

image

@michael-valdron
Copy link
Member Author

PR ready for review: devfile/registry#256

@michael-valdron michael-valdron moved this from In Progress 🚧 to In Review 👀 in Devfile Project Dec 8, 2023
@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure area/releng Release engineering
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant