Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workspace devfile #256

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Dec 4, 2023

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Adds a devfile and resource files to build and deploy the community devfile registry.

Additionally adds ignore for odo project dotfile.

Which issue(s) this PR fixes:

Link to github issue(s)

fixes devfile/api#1200

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Copy link

openshift-ci bot commented Dec 4, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved label Dec 4, 2023
@michael-valdron michael-valdron changed the title Create workspace devfile WIP: Create workspace devfile Dec 4, 2023
@michael-valdron michael-valdron force-pushed the feat/devfile branch 25 times, most recently from e6c1597 to 0804307 Compare December 7, 2023 23:06
Signed-off-by: Michael Valdron <[email protected]>
@michael-valdron michael-valdron force-pushed the feat/devfile branch 3 times, most recently from 8f15328 to 3381ea0 Compare December 8, 2023 21:12
@michael-valdron michael-valdron marked this pull request as ready for review December 8, 2023 21:20
@michael-valdron michael-valdron changed the title WIP: Create workspace devfile Create workspace devfile Dec 8, 2023
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to deploy locally but I get some errors. Might be related to my setup.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
…try-community' on README.md#L70

Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally looks good after the updates and I was able to deploy the registry pretty easy. I left a quick comment for the readme :)

README.md Show resolved Hide resolved
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 7fac76a into devfile:main Dec 19, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create devfile for devfile registry deployments
2 participants