Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Registry Viewer tags display #1289

Closed
kim-tsao opened this issue Oct 16, 2023 · 5 comments · Fixed by devfile/devfile-web#104 or devfile/registry-support#193
Closed

Fix Registry Viewer tags display #1289

kim-tsao opened this issue Oct 16, 2023 · 5 comments · Fixed by devfile/devfile-web#104 or devfile/registry-support#193
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure demo Issue or PR candidate for a demo at the end of the Sprint kind/bug Something isn't working

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Oct 16, 2023

Which area this feature is related to?

/kind bug

Bug Summary

Describe the bug:

Separated out from issue #1064 as an independent bug.

  • The tags are pulled from all devfile versions of a specific runtime which is incorrect. It should only display the tags for a specific runtime version.
  • Similarly, the tags shown on the registry viewer tiles represent tags from all runtime versions when it should only display the tags for the default devfile. This means if the default devfile is not deprecated, then the deprecated tag should not show up. Users would only see it if they click on the tile and toggle between versions.

To Reproduce:

We can't use the community registry viewer because tags are common across all stack runtime versions.

To reproduce:

  1. Clone the https://github.com/devfile/registry-support repo
  2. (Optional) Add the Deprecated tag to one of the go stack versions
  3. Build the registry by following the instructions: https://github.com/devfile/registry-support/tree/main#build
  4. Deploy to a cluster and bring up the local viewer.

For the Go stack time, note that it displays all the tags from all stack versions:

image

Click on the tile, and note that when you switch runtime versions, the tags do not change

Expected behavior

Tags should only reflect the selected stack version

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Additional context

Any workaround?

Suggestion on how to fix the bug

@openshift-ci openshift-ci bot added the kind/bug Something isn't working label Oct 16, 2023
@kim-tsao kim-tsao moved this to To Do 📝 in Devfile Project Oct 16, 2023
@michael-valdron michael-valdron added the area/registry Devfile registry for stacks and infrastructure label Oct 16, 2023
@thepetk thepetk self-assigned this Oct 16, 2023
@kim-tsao kim-tsao moved this from To Do 📝 to Backlog in Devfile Project Oct 16, 2023
@thepetk thepetk added the demo Issue or PR candidate for a demo at the end of the Sprint label Oct 16, 2023
@thepetk thepetk moved this from Backlog to To Do 📝 in Devfile Project Oct 16, 2023
@thepetk thepetk moved this from To Do 📝 to In Progress 🚧 in Devfile Project Oct 20, 2023
@thepetk
Copy link
Contributor

thepetk commented Oct 20, 2023

Created a PR for this issue. I've also added a new color for the Deprecated tag. So every time that a stack has Deprecated as tag the color changes (becomes red).

@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Oct 20, 2023
@thepetk thepetk moved this from In Review 👀 to Done ✅ in Devfile Project Oct 23, 2023
@thepetk thepetk moved this from Done ✅ to In Review 👀 in Devfile Project Oct 23, 2023
@thepetk
Copy link
Contributor

thepetk commented Oct 23, 2023

Re-opening as PR was accidentally pointing to another branch. I have created again a PR pointing to main devfile/devfile-web#104

cc @kim-tsao @michael-valdron

@thepetk
Copy link
Contributor

thepetk commented Dec 5, 2023

I'm re-openning the issue as I've noticed two things:

  1. The registry-support adds all tags for all stack versions into the generic (grid) view. As a result we should add a fix into the registry support repo. Fix here: Add only default tags in indexComponent registry-support#193
  2. The color Deprecated is not visible anymore (while it was when we first deployed it).

cc @kim-tsao

@thepetk
Copy link
Contributor

thepetk commented Dec 7, 2023

The registry-support adds all tags for all stack versions into the generic (grid) view. As a result we should add a fix into the registry support repo. Fix here: devfile/registry-support#193

Fixed as the related PR is merged.

I'm re-opening as the color-related issue still exists

@thepetk thepetk reopened this Dec 7, 2023
@thepetk thepetk moved this from Done ✅ to In Progress 🚧 in Devfile Project Jan 25, 2024
@thepetk thepetk moved this from In Progress 🚧 to Done ✅ in Devfile Project Jan 25, 2024
@thepetk
Copy link
Contributor

thepetk commented Jan 25, 2024

Closing. Will create a separate color issue.

@thepetk thepetk closed this as completed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure demo Issue or PR candidate for a demo at the end of the Sprint kind/bug Something isn't working
Projects
Status: Done ✅
3 participants