Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Viewer tags #104

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Fix Viewer tags #104

merged 2 commits into from
Oct 24, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Oct 23, 2023

What does this PR do / why we need it

Re opening a PR for devfile/api#1289 in order to merge the accidentally created branch to main. Previous PR was: #103

Which issue(s) does this PR fix

Fixes devfile/api#1289

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer

@thepetk thepetk self-assigned this Oct 23, 2023
@openshift-ci openshift-ci bot requested a review from elsony October 23, 2023 18:52
* Add functions for devfile tags

Signed-off-by: thepetk <[email protected]>

* Update detailed view and grid

Signed-off-by: thepetk <[email protected]>

* Create new color in tailwind

Signed-off-by: thepetk <[email protected]>

* Apply format

Signed-off-by: thepetk <[email protected]>

---------

Signed-off-by: thepetk <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Oct 24, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

New changes are detected. LGTM label has been removed.

@thepetk thepetk merged commit 0b89f91 into main Oct 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Registry Viewer tags display
2 participants