Update contributing guide #1597
Conversation
Signed-off-by: Michael Valdron <[email protected]>
michael-valdron
requested review from
amisevsk,
yangcao77 and
johnmcollier
as code owners
N/A |
| By contributing to this project you agree to the Developer Certificate of | ||
| Origin (DCO). This document was created by the Linux Kernel community and is a | ||
| simple statement that you, as a contributor, have the legal right to make the | ||
| contribution. See the [DCO](DCO) file for details. |
There was a problem hiding this comment.
invalid link for DCO file
There was a problem hiding this comment.
fixed in fd6dd3f, missed that this repository was also missing the DCO file.
CONTRIBUTING.md
Outdated
|
|
||
| After addressing review comments, don’t forget to add a comment in the PR afterward, so everyone gets notified by Github and knows to re-review. | ||
| If you have any questions, please visit us the `#devfile` channel under the [Kubernetes Slack](https://slack.k8s.io) workspace. |
There was a problem hiding this comment.
There was a problem hiding this comment.
@yangcao77 @thepetk How is this change? aa7e5b3
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
|
The follow up changes for the feedback above should be include in the contributing guide template #1591 and updated in all repositories to be consistent. FYI @yangcao77 @thepetk |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: michael-valdron, thepetk, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
Updates contributing guide and supporting documents with up to date information and layout.
Additionally, adds missing DCO file into repository.
Which issue(s) does this PR fix
fixes #1346
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer