-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix doc link in readme #1689
Fix doc link in readme #1689
Conversation
d17e8f9
to
4166630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase, recent PR merge fixes these failing checks: #1666
ece1a06
to
a610705
Compare
rephrasing to avoid using `here` for link text Signed-off-by: Clay Rosenthal <[email protected]> Signed-off-by: Clay Rosenthal <[email protected]>
a610705
to
83171eb
Compare
@thepetk @michael-valdron rebased properly now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: clayrosenthal, Jdubrick, michael-valdron, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
Updating the link to the generated documentation. Rephrasing to avoid using
here
for link text to have more readable links.Related Issue(s)
fixes #1688
Acceptance Criteria
If criteria is left unchecked please provide an explanation why.
No code changes
No code changes
Updating link
No code changes
Tests Performed
Clicked link.
How To Test
Click the link and don't end up with a dead page.
Notes To Reviewer
Feel free to rephrase if you don't like my wording.