Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc link in readme #1689

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

clayrosenthal
Copy link
Contributor

Description of Changes

Updating the link to the generated documentation. Rephrasing to avoid using here for link text to have more readable links.

Related Issue(s)

fixes #1688

Acceptance Criteria

If criteria is left unchecked please provide an explanation why.

  • Unit/Functional tests

No code changes

No code changes

  • Documentation

Updating link

  • Client Impact

No code changes

Tests Performed

Clicked link.

How To Test

Click the link and don't end up with a dead page.

Notes To Reviewer

Feel free to rephrase if you don't like my wording.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase, recent PR merge fixes these failing checks: #1666

rephrasing to avoid using `here` for link text

Signed-off-by: Clay Rosenthal <[email protected]>
Signed-off-by: Clay Rosenthal <[email protected]>
@clayrosenthal
Copy link
Contributor Author

@thepetk @michael-valdron rebased properly now

Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: clayrosenthal, Jdubrick, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 22740cb into devfile:main Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix schema documentation link in README
4 participants