-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build linux/arm64 ubi9 universal image in GH action #213
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: dkwon17 <[email protected]>
@dkwon17 in Dockerfile Some binaries that are downloaded are specific to the amd64 architecture. Should we adapt them for arm64 compatibility? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, ibuziuk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@svor good idea, I'll see if I can do that this Friday |
Signed-off-by: David Kwon <[email protected]>
New changes are detected. LGTM label has been removed. |
Signed-off-by: David Kwon <[email protected]>
Signed-off-by: David Kwon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dkwon17 did you have a chance to build udi for arm64?
I've tried DOCKER_BUILDKIT=1 docker image build --platform linux/arm64 --progress=plain -t quay.io/devfile/universal-developer-image:ubi9-latest .
but had an error:
#9 0.387 exec /bin/sh: exec format error
#9 ERROR: process "/bin/sh -c touch ${PROFILE_EXT} && chown 10001 ${PROFILE_EXT}" did not complete successfully: exit code: 1
------
> [ 2/44] RUN touch /etc/profile.d/udi_environment.sh && chown 10001 /etc/profile.d/udi_environment.sh:
0.387 exec /bin/sh: exec format error
------
Dockerfile:26
--------------------
24 | # $PROFILE_EXT contains all additions made to the bash environment
25 | ENV PROFILE_EXT=/etc/profile.d/udi_environment.sh
26 | >>> RUN touch ${PROFILE_EXT} && chown 10001 ${PROFILE_EXT}
27 |
28 | USER 10001
It would be nice to have a PR check that checks image build for all arches
Yes, I was able to build for the udi for arm64 with this PR, I will investigate |
Adds the linux/arm64 platform, just like in the ubi build:
developer-images/.github/workflows/ubi9-build.yaml
Line 58 in e24cbd7